Always operate in blocking mode

bschmitt / laravel-amqp

AMQP wrapper for Laravel and Lumen to publish and consume messages

MIT License

268 stars 86 forks source link

Closed lukebakken closed 5 years ago

lukebakken commented 5 years ago

Due to changes in php-amqplib/php-amqplib#642, non-blocking mode does not use a timeout, which results in an infinite loop and high CPU.

This change ensures that only blocking mode is used.

Fixes #63

Also see php-amqplib/php-amqplib#729

lukebakken commented 5 years ago

@ramunasd would you mind verifying this change?

ramunasd commented 5 years ago

Looks good to me

pawel-marciniak commented 5 years ago

Anyone knows when this will be merged?

stevenklar commented 5 years ago

Will merge tonight most likely. Thanks for the contribution!

bschmitt commented 5 years ago

Thank y’all for your contribution! In case @stevenklar doesn’t find time, i take care.

stevenklar commented 5 years ago

Release will be 2.0.8 and I will also bump the composer version. Signature of wait is the same but old implementations might have side effects.

lukebakken commented 5 years ago

Hey everyone, thanks for the quick turnaround! :1st_place_medal: