bschmitt / laravel-amqp

AMQP wrapper for Laravel and Lumen to publish and consume messages
MIT License
270 stars 86 forks source link

Publish multiple messages - Batch publish #91

Closed filipbekic01 closed 4 years ago

filipbekic01 commented 4 years ago

I'm having trouble pushing 200+ messages at once. Each publish takes ~2 seconds, that's really slow.

joskfg commented 4 years ago

I'm having the same issue and this library doesn't support it. It uses basic_publish and there isn't any option to use batch_basic_publish.

filipbekic01 commented 4 years ago

I'd love to extend possibilities but i'm not even sure how active this repository is. I see there are 3 PRs in queue already :-1:

bschmitt commented 4 years ago

The library doesn't support batch_basic_publish for now. But feel free to provide a PR. There are 3 PRs in review, some of them don't follow the intention of this library.

stevenklar commented 4 years ago

Hey Filip, I would love to merge any appropriate enhancement to the repository. Just create a PR and follow the repositories purpose.

Thank you :-)

On Wed, 7 Oct 2020 at 21:12, Björn Schmitt notifications@github.com wrote:

The library doesn't support batch_basic_publish for now. But feel free to provide a PR. There are 3 PRs in review, some of them don't follow the intention of this library.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bschmitt/laravel-amqp/issues/91#issuecomment-705138824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC4WAWXG6R5VHC2ZXOQRL3SJS4TLANCNFSM4SE6N2JQ .

joskfg commented 4 years ago

I created a version of this library, with the support. After further testing, I'd like to put here as PR.

filipbekic01 commented 4 years ago

Do that @joskfg :+1:

joskfg commented 4 years ago

Initial approach https://github.com/bschmitt/laravel-amqp/pull/93

stevenklar commented 4 years ago

Thank you for the contribution. I would like to merge this for our next release. Please fix the necessary docblocks and appropriate method scope.

-Steven

joskfg commented 4 years ago

Fixed docblocks and method scope.

stevenklar commented 4 years ago

Will be published in the next release.