bschwarz / puml-themes

This repository is used to hold themes for plantuml (www.plantuml.com) diagraming tool. Users can use these themes to give there diagrams different looks.
MIT License
261 stars 69 forks source link

Swimlanes styling #7

Open GauntletPL opened 4 years ago

GauntletPL commented 4 years ago

In the new Activity Diagram syntax, there is a feature of grouping activities under the Swimlanes. Those Swimlanes are not addressed by the themes:

image

bschwarz commented 4 years ago

Sorry for the late reply. I will take a look. Do you happen to have the plantuml file that generated the above image? So I can see exactly what you are talking about.

Thanks Brett

GauntletPL commented 4 years ago

I don't have exactly that .puml any more, but this should be close enough:

@startuml

title Activity Diagram Title

|Mobile App|
start
    :Navigate to selected reward;
    :Claim selected reward;
    |System in the middle|
    :Validate redemption (*);
        |Target system|
        :Issue claimed reward;
stop

@enduml
bschwarz commented 4 years ago

Ok, I added the following:

There is a new example diagram for swimlane now, it's the second diagram under each theme.

Let me know if this is what you were looking for or not. Any feedback about the colors too will help.

Cheers, Brett

GauntletPL commented 4 years ago

Thank you Brett for the provided changes. they look pretty neat. One issue that I can see, however, is that with the background colour approach, the background box is sticking out unaesthetically beyond the rightmost vertical line. Maybe it'd be better to drop the background colour altogether and just rely on the appropriate font accentuation.

Below is my, rather poor attempt at illustration of what I mean (just made the font bigger and bold):

image

Either way, I'll be fine with whatever approach you'll decide to go on with ;)