Bug in python Implementation of IR slinger

[adithyaselv]

I guess its probably a typo or something line 111 of pyslinger.py NEC protocol Zero and ones

def zero(self):
        self.wave_generator.one(self.one_pulse_duration)
        self.wave_generator.zero(self.zero_pulse_duration)

    # One is represented by a pulse and a gap three times longer than the pulse
def one(self):
        self.wave_generator.one(self.zero_pulse_duration)
        self.wave_generator.zero(self.zero_gap_duration)

it should be

def zero(self):
        self.wave_generator.one(self.zero_pulse_duration)
        self.wave_generator.zero(self.zero_gap_duration)

    # One is represented by a pulse and a gap three times longer than the pulse
def one(self):
        self.wave_generator.one(self.one_pulse_duration)
        self.wave_generator.zero(self.one_gap_duration)

to get it work correct Thanks

[bschwind]

Hey, thanks for the heads up. Would you mind creating a pull request with your proposed changes?

[adithyaselv]

Aha since it was a small thing I thought you could do it yourself ! Cool work Btw 😃

[bschwind]

Ah you formatted your post, I can see the change more clearly now. Yeah it's a one line change, I can go ahead and fix it.

EDIT - Well, not "one-line", but I see what needs to be changed now.

[adithyaselv]

Aha yea ! 👍