bschwind / mqtt-broker

A tokio-based MQTT v5 broker written in pure Rust [WIP]

MIT License

140 stars 24 forks source link

Fix decode variable int bug #20

Closed TakuKitamura closed 4 years ago

TakuKitamura commented 4 years ago

decode_variable_int Func Bug

The algorithm for decoding variable byte integers was wrong, so I fixed it. Specifically, the implementation of the arithmetic part of the "multiplier" is different. (reference: https://docs.oasis-open.org/mqtt/mqtt/v5.0/os/mqtt-v5.0-os.html#_Toc3901011)
add test for decode_variable_int function

note: The normal system test has been done, but the abnormal system test has not been done, so there may be some parts that still need to be corrected.

bschwind commented 4 years ago

Sorry about CI, rustfmt has been broken in nightly. I'll give this a review when I'm home tonight, thanks for submitting it!

bschwind commented 4 years ago

Everything looks good, thanks for writing the test as well!

Later I might try to write a test that just loops through all integers from 0 to 268435455 and does an encode->decode roundtrip. I wonder how slow that would be...