search

bscrow / pe

0 stars 0 forks source link

CAP is not updated in the GUI #9

Open bscrow opened 4 years ago

bscrow commented 4 years ago

After the cap command, the cap in the GUI is not updated.

Steps to replicate:

moduleAdd m/CS2040 g/A cap

image.png

nus-pe-bot commented 4 years ago

Team's Response

Was stated clearly in the UG that

"Shows current CAP in in result display panel, CAP on UI will only get updated after you restart."

Screen Shot 2020-04-18 at 4.38.55 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If that is the expected behaviour of your app, I would consider this behaviour a feature flaw with medium severity of your app.

CAP in the UI is much more obvious than the CAP in the CLI, as 1. the CAP value in the GUI is more persistent; if you enter another command, the CAP in the CLI disappears but the CAP in the GUI persists. 2. There is no mention in the app itself whether this value is updated. This can easily confuse the user (if the CAP is not updated, why am I seeing it?).

This issue can be easily solved by storing CAP as an observableValue that the UI can observe and update everytime CAP changes. Since it is not due to some constraint of JavaFX, I think this behaviour is a flaw of the app, even if you have stated that this is the expected behaviour in the UG.