bsd-ac / wayland-desktop

Gentoo overlay for Wayland related ebuilds
https://gentoo.org
ISC License
61 stars 21 forks source link

gui-apps/wayfire: "default" in src_install() doesn't install the binaries #4

Closed Zuccace closed 4 years ago

Zuccace commented 4 years ago

Looks like portage's default install doesn't do anything... Even with "meson" eclass inherited.

Maybe follow upstream instructions instead of relying to "default"? https://github.com/WayfireWM/wayfire#build-and-install

I'll try to figure out why this happens as I get more time to concentrate more on this.

Zuccace commented 4 years ago
+ local retval
+ src_install
+ default
+ default_src_install
+ __eapi6_src_install
+ [[ -f Makefile ]]
+ [[ -f GNUmakefile ]]
+ [[ -f makefile ]]
+ einstalldocs

Sure it only searches for regular makefiles... So meson.eclass src_install() doesn't include/run meson_src_install(). We need to run it manually:

src_install() {
        default
        meson_src_install

        insinto "/usr/share/wayland-sessions/";
        insopts -m644;
        doins wayfire.desktop;

        insinto "/usr/share/doc/${P}/";
        insopts -m644;
        doins wayfire.ini.default;
}

Please test and run wayfire. I haven't tested this much. I only observed that the files are now installed (hopefully) in right directories.

epsilon-0 commented 4 years ago

Oh wow. Thats some awesome debugging!

Thanks a lot for the info. I've checked and verified that this works. I've added this to all 3 ebuilds for wayfire (including the 9999).

I'm travelling right now (till end of January) so I can't do too much debugging but I can check small things.

Zuccace commented 4 years ago

No problem. :) I have few fixes in my mind. l'll create issues or pull requests if needed as I explore wayfire. ;) -- Ilja Sara

On January 6, 2020 11:50:21 AM UTC, Abhinav Tamaskar notifications@github.com wrote:

Oh wow. Thats some awesome debugging!

Thanks a lot for the info. I've checked and verified that this works. I've added this to all 3 ebuilds for wayfire (including the 9999).

I'm travelling right now (till end of January) so I can't do too much debugging but I can check small things.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/epsilon-0/wayfire-desktop/issues/4#issuecomment-571111083