Closed gbrlsnchs closed 1 year ago
0.2.3 just landed with bugfixes, bumped it here!
river seems to compile some C code during build. I added a patch that passes down CFLAGS
to the build step.
Great work!
I tried the ebuild on my system, and the patches are causing me issues since I use LTO:
error(compilation): clang failed with stderr: zig: error: unknown argument: '-fgraphite-identity'
zig: error: unknown argument: '-floop-nest-optimize'
zig: error: unknown argument: '-fdevirtualize-at-ltrans'
zig: error: unknown argument: '-fipa-pta'
zig: error: unsupported argument '12' to option '-flto='
zig: warning: -Wl,-O1: 'linker' input unused [-Wunused-command-line-argument]
zig: warning: -Wl,--as-needed: 'linker' input unused [-Wunused-command-line-argument]
zig: warning: optimization flag '-fuse-linker-plugin' is not supported [-Wignored-optimization-argument]
zig: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]
I mean, this technically doesn't have to be supported... would there be a way to have custom CFLAGS as a USE-flag? Or is it wrong behaviour? Should these flags all be passed to clang instead? It seems they are passed to zig...
However, it works perfectly fine without the patch.
@BurnyLlama I think I'll simply drop the patch for now, it's way out of scope and totally not worth it, it's literally a single C file that serves for logging only.
@gbrlsnchs oh, I thought it was major parts of river. Yeah, then it's most likely not worth bothering. 😅
I concur, the patch is unneeded. The rest looks good, I'll try to merge tonight.
BTW @Muirrum once tried to add gui-wm/river
to GURU overlay, but things went south because I dropped 0.9.1 (dep on LLVM 13) in main repository (as you already know 😄 , seems like you returned binary version unlike GURU that mustn't overwrite version). You may want to cooperate tho
Rebased the ebuild with the requested changes!
Fixes #43.