search

bsdci / libioc

A Python library to manage jails with ioc{age,ell}
https://bsd.ci/libioc
Other
38 stars 11 forks source link

Comply with flake8 A001, A002, A003 and A004 #296

Open gronke opened 6 years ago

gronke commented 6 years ago

This output was taken from a recent build on Travis CI:

flake8 --exclude=".travis,.eggs,__init__.py" --ignore=E203,W391,D107,A002
./iocage/lib/events.py:135:5: A001 "type" is a python builtin and is being shadowed, consider renaming the variable
./iocage/lib/helpers.py:134:1: A001 "exec" is a python builtin and is being shadowed, consider renaming the variable
./iocage/lib/Jail.py:874:1: D102 Missing docstring in public method
./iocage/lib/Jail.py:1015:5: A001 "exec" is a python builtin and is being shadowed, consider renaming the variable
./iocage/lib/Config/Jail/BaseConfig.py:544:5: A001 "set" is a python builtin and is being shadowed, consider renaming the variable
./iocage/lib/Config/Jail/Properties/Addresses.py:98:5: A001 "set" is a python builtin and is being shadowed, consider renaming the variable
./iocage/lib/Config/Jail/Properties/Interfaces.py:49:5: A001 "set" is a python builtin and is being shadowed, consider renaming the variable
./iocage/lib/Config/Jail/Properties/Resolver.py:108:5: A001 "set" is a python builtin and is being shadowed, consider renaming the variable

It indicates that libiocage violates A001 by re-declaring builtin variable names.

gronke commented 6 years ago

The warnings were disabled in #297 so that further PRs are not blocked.

gronke commented 6 years ago

This caused a multitude of chore PRs to sequentially ignore A001 to A004 😠I really wonder why they didn't show up at the same time and also what is different between them.