Enhance Puppet Provisioning

bsdci / libioc

A Python library to manage jails with ioc{age,ell}

https://bsd.ci/libioc

Other

38 stars 11 forks source link

Enhance Puppet Provisioning #726

Closed gronke closed 5 years ago

gronke commented 5 years ago

[x] test puppet provisioner
[x] refactor puppet provisioner
[x] make is_path_relative() and require_relative_path() methods of JailGenerator public
[ ] allow cloning manifests from remote sources without connecting the jail to any network

gronke commented 5 years ago

@igalic It should be possible to clone the manifest with the Python git module, so that no internet is required for this step. Can you imagine to create a super simple puppet manifest, that does something we can test. For example touch a file in the jails root directory? The current example manifest requires internet, which is a bit unfortunate in automated tests.

igalic commented 5 years ago

It should be possible to clone the manifest with the Python git module, so that no internet is required for this step.

yesno: r10k also fetches the required modules specified in the Puppetfile in the repository that is cloned

Can you imagine to create a super simple puppet manifest, that does something we can test. For example touch a file in the jails root directory? The current example manifest requires internet, which is a bit unfortunate in automated tests.

file { '/foo':
  ensure => present,
  content => 'puppet test',
}

gronke commented 5 years ago

Thanks for looking into it, @igalic. Would you mind to apply the changes to this branch? I'll then fit the test, so that we can go ahead and add more specific tests.