bsdlabs / ssh-hardening

FreeBSD SSH Hardening
https://github.com/jtesta/ssh-audit/wiki/FreeBSD
BSD 2-Clause "Simplified" License
25 stars 4 forks source link

Add SSH client hardening guide #11

Closed jlduran closed 1 year ago

jlduran commented 2 years ago

Close #2

koobs commented 2 years ago

Can you include/list the main changes of the changeset/PR in the PR description, so I can grok the diff and rationale:

jlduran commented 2 years ago

Done! You can see the proposed outcome here.

koobs commented 2 years ago

LGTM with my minor copy edit suggestions

Should Add sk-ssh-ed25519@openssh.com and sk-ssh-ed25519-cert-v01@openssh.com to client14.md once libfido2 et al. are wired in (D32448, D32509) now be split out into a separate issue, such that we can merge what we have?

Thank you for adding the client hardening parts!

jlduran commented 2 years ago

LGTM with my minor copy edit suggestions

What copy edit suggestions?


Maybe I can add those now, that way we'll avoid the need to resubmit upstream (even if they do nothing at the moment).(done)

koobs commented 2 years ago

LGTM with my minor copy edit suggestions

What copy edit suggestions?

Sorry I missed this mate, screenshot of review comment:

image

jlduran commented 2 years ago

Done!

jlduran commented 2 years ago

Note to self: FreeBSD 12.3-RELEASE & 13.1-RELEASE, when released should use the same client14.md file, hence making this PR much simpler.