Closed jlduran closed 1 year ago
Can you include/list the main changes of the changeset/PR in the PR description, so I can grok the diff and rationale:
LGTM with my minor copy edit suggestions
Should Add sk-ssh-ed25519@openssh.com and sk-ssh-ed25519-cert-v01@openssh.com to client14.md once libfido2 et al. are wired in (D32448, D32509)
now be split out into a separate issue, such that we can merge what we have?
Thank you for adding the client hardening parts!
LGTM with my minor copy edit suggestions
What copy edit suggestions?
Maybe I can add those now, that way we'll avoid the need to resubmit upstream (even if they do nothing at the moment).(done)
LGTM with my minor copy edit suggestions
What copy edit suggestions?
Sorry I missed this mate, screenshot of review comment:
Done!
Note to self: FreeBSD 12.3-RELEASE & 13.1-RELEASE, when released should use the same client14.md
file, hence making this PR much simpler.
Close #2