search

bsdpot / pot

pot: another container framework for FreeBSD, based on jails, ZFS and pf
BSD 3-Clause "New" or "Revised" License
333 stars 31 forks source link

Remove basepath from mountpoint #259

Closed urosgruber closed 11 months ago

urosgruber commented 1 year ago

There are a couple of things that changed here

  1. update the mount method to append the actual jail root path
  2. update how mount-in stores the path without prefixing with the jail root path
  3. fix clone to copy file since no need to fix anything

The missing bit is probably to remove two lines from rename command because no replacement is required.

I haven't checked if anything breaks with the datasets.

But the process of creating pot, with some mounts, exporting it, and then import with additional clone makes everything as it should be.

This fixes #257

pizzamig commented 1 year ago

Hi. I like this approach, it makes the code simpler. Need to run few tests with it, but it seems a good idea

pizzamig commented 1 year ago

I've pushed several changes, but I'd like to do more tests before to commit it

bretton commented 1 year ago

@bretton @hny-gd @pizzamig Does one of happen to have the time to also look at this/give feedback/input.

I've done a test building a cluster environment using files from the PR, and all is working fine

grembo commented 11 months ago

@bretton @hny-gd @pizzamig Hi guys, what about finishing this?

pizzamig commented 11 months ago

Hi. It works for me as well