Patches for review

[GoogleCodeExporter]

Please review and commit the changes if you are happy with them.

Original issue reported on code.google.com by moyesyside on 14 Feb 2014 at 10:05

Attachments:

• biocache.patch

[GoogleCodeExporter]

Original comment by moyesyside on 14 Feb 2014 at 10:05

Attachments:

• biocache-service.patch

[GoogleCodeExporter]

Original comment by moyesyside on 14 Feb 2014 at 10:06

Attachments:

• biocache-config.properties

[GoogleCodeExporter]

Hi Dave I have attached the patch for biocache-store to make the 
ValidationRuleRunner work correctly.

I still need to make some modifications to biocache-service.

Original comment by natasha....@csiro.au on 7 Mar 2014 at 1:50

Attachments:

• Fix_to_make_ValidationRuleRunnerwork.patch

[GoogleCodeExporter]

Here are the revised patches for biocache-service and store. 

After digging around more in the code there were some changes made that would 
have broken the ability to update a validation rule. I have fixed this in the 
patch. Also the new validation rule code relies on id's in a different format 
to the old queryassertions.  Thus I had to provide a retrofit method to allow 
the id's to be changed to the correct format.

Without this change the existing validation rules will not be able to be 
updated via a JCU update. 

I have also provide a WS that will allow species to be rematched to the new 
names. Also support for validation rules that supply a query and NO species.

Let me know if this doesn't make sense.

I have tested my changes to the validation rules and they seem to be working.

Was there any other major area of changed in the restructure that I need to 
perform a code review of?

Original comment by natasha....@csiro.au on 7 Mar 2014 at 4:20

Attachments:

• Fix_to_make_ValidationRuleRunner_work_and_retrofitids.patch
• update_insert_rules_rematch_species_query.patch

[GoogleCodeExporter]

I suggest that we make these reshuffled versions of the biocache-store and 
service make use of the reshuffled ala-name-matching.  That way we can release 
them together.

Thoughts? Objections?

Original comment by natasha....@csiro.au on 10 Mar 2014 at 10:19

[GoogleCodeExporter]

sounds good to me. I'll review the patches and get back to you.

Original comment by moyesyside on 10 Mar 2014 at 11:49

[GoogleCodeExporter]

Closed because patches are now on trunk

Original comment by natasha....@csiro.au on 3 Apr 2014 at 3:39

• Changed state: Done