bsed / ala

Automatically exported from code.google.com/p/ala
0 stars 0 forks source link

Add to Map | Area not detecting invalid topology #610

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
"Add to Map | Facet | Lifeform" produces no list after a minute...see attached.

Tried with 6 different facets but no facet classes listed. Major bust somewhere.

Original issue reported on code.google.com by leebel...@gmail.com on 14 Mar 2014 at 12:02

Attachments:

GoogleCodeExporter commented 9 years ago
Sorry Lee - worked for me. Adam can you test & Lee re-test. If ok suggest we 
close.

Original comment by moyesyside on 14 Mar 2014 at 12:22

GoogleCodeExporter commented 9 years ago
Just did a re-start and now ok. Possibly browser cache issue. Adam - ok for you?

Original comment by leebel...@gmail.com on 14 Mar 2014 at 12:34

GoogleCodeExporter commented 9 years ago
Lee, were you using a user drawn polygon area to filter the selection?

User drawn polygons are not subject to the same validation as other WKT 
sources.  e.g. you can draw POLYGON((128.97862577438 
-25.751118120764,141.17344999313 -25.731325925864,141.12
950468062 -40.972184698777,133.08751249313 -36.589686404624,129.85753202437 
-34.480026475391,128.97862577438 -34.71515737246,129.00059843063 
-34.71515737246,128.97862577438 -25.751118120764)) but you cannot enter it 
directly or use the drawn area in facets.

Need to apply area validation to user drawn polygons and anything else that is 
missed.  I recall some contextual layers having invalid areas (self 
intersecting) and requiring manual correction.  

Original comment by adam.col...@gmail.com on 14 Mar 2014 at 12:46

GoogleCodeExporter commented 9 years ago
The problem was a user-digitised polygon (Add to Map | Areas | Draw polygon) 
that had an invalid topology. Pasting a WKT will result in a topological check, 
but not on-the-fly digitizing. Need to add check code to add to map | areas

Original comment by leebel...@gmail.com on 14 Mar 2014 at 1:36

GoogleCodeExporter commented 9 years ago
Added the validation to user drawn polygons.

Still need to add the validation to user uploaded shapes.

Original comment by adam.col...@gmail.com on 20 Mar 2014 at 11:53

GoogleCodeExporter commented 9 years ago
Dev: Validated invalid topology

Original comment by leebel...@gmail.com on 21 Mar 2014 at 12:57

GoogleCodeExporter commented 9 years ago
Renamed issue to reflect the problem, not a side effect

Original comment by leebel...@gmail.com on 21 Mar 2014 at 12:59

GoogleCodeExporter commented 9 years ago
Added validation.

Original comment by adam.col...@gmail.com on 1 May 2014 at 12:39

GoogleCodeExporter commented 9 years ago
Tested nicely. Meaningful error returned.

ToProd.

Original comment by leebel...@gmail.com on 2 May 2014 at 6:32

GoogleCodeExporter commented 9 years ago

Original comment by adam.col...@gmail.com on 19 May 2014 at 9:27