Mouse up when opening a custom fold closes it again

bsegraves / custom-folds

Atom plugin for defining custom markers for foldable regions.

MIT License

24 stars 9 forks source link

Mouse up when opening a custom fold closes it again #32

Closed ColinT closed 7 years ago

ColinT commented 7 years ago

When opening a custom fold, the fold opens on mouse down. If the cursor is not moved, the fold closes again on mouse up. Dragging the cursor to a different location before mouse up does not cause this behaviour.

Steps to reproduce:

Make a custom fold section
Close the fold
Open the fold by clicking, without moving the cursor between mouse down and mouse up

Occurs on atom v1.19.0 bsegraves/custom-folds v1.9.4

bsegraves commented 7 years ago

Thanks for the report. This is new behavior, presumably started with atom 1.19. It looks like atom is handling the event before we get informed of it. Not entirely sure how to work around this yet.

MaximeDawn commented 7 years ago

Same issue here, just to mention, because none of you did it, if you just drag a little the mouse beetween mouse down and mouse up, the problem does not occur. 😉

eskemojoe007 commented 7 years ago

Also, clicking the small ... icon to the right of text works, but I am experiencing the same behavior.

This is occuring in Atom 1.19.7 ia32 with custom-folds 1.9.4

bsegraves commented 7 years ago

Sorry this took so long to fix. I've been slammed at work.

Version 1.9.5 is up and fixes this.

Let me know if you encounter any problems.