bseltz-cohesity / scripts

Cohesity REST API examples in PowerShell and Python
Apache License 2.0
102 stars 41 forks source link

Wrong API call in scripts/python/nodeRemove/nodeRemove.py #29

Closed SerErris closed 3 years ago

SerErris commented 3 years ago

Hi Brain,

can you please check scripts/python/nodeRemove/nodeRemove.py ? It looks like that the API call is wrong.

According to our documentation it is supposed to be that: DELETE /public/clusters/nodes/{id}

But in your python code you have this: result = api('post', "/nodes/%i" % selectedNodeId)

I think it should read result = api('delete', "/nodes/%i" % selectedNodeId)

I looked into 6.5.1 docu here: https://developer.cohesity.com/apidocs-651.html#/rest/api-endpoints/clusters/remove-node

bseltz-cohesity commented 3 years ago

Im using a different (not public) API call. It works fine. At the time I wrote that script, the public API call did not exist.

On Sat, Jun 5, 2021 at 8:46 AM Christoph Linden @.***> wrote:

Hi Brain,

can you please check scripts/python/nodeRemove/nodeRemove.py ? It looks like that the API call is wrong.

According to our documentation it is supposed to be that: DELETE /public/clusters/nodes/{id}

But in your python code you have this: result = api('post', "/nodes/%i" % selectedNodeId)

I think it should read result = api('delete', "/nodes/%i" % selectedNodeId)

I looked into 6.5.1 docu here:

https://developer.cohesity.com/apidocs-651.html#/rest/api-endpoints/clusters/remove-node

β€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bseltz-cohesity/scripts/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJILKHNZJFLIHFUCRSOVYW3TRIMDDANCNFSM46EQIMBA .

--

Brian Seltzer Field Technical Director - East +1(484)356-3428 @.***

bseltz-cohesity commented 3 years ago

In my scripts, a leading / means Non-public API call.

On Sat, Jun 5, 2021 at 8:48 AM Brian Seltzer @.***> wrote:

Im using a different (not public) API call. It works fine. At the time I wrote that script, the public API call did not exist.

On Sat, Jun 5, 2021 at 8:46 AM Christoph Linden @.***> wrote:

Hi Brain,

can you please check scripts/python/nodeRemove/nodeRemove.py ? It looks like that the API call is wrong.

According to our documentation it is supposed to be that: DELETE /public/clusters/nodes/{id}

But in your python code you have this: result = api('post', "/nodes/%i" % selectedNodeId)

I think it should read result = api('delete', "/nodes/%i" % selectedNodeId)

I looked into 6.5.1 docu here:

https://developer.cohesity.com/apidocs-651.html#/rest/api-endpoints/clusters/remove-node

β€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bseltz-cohesity/scripts/issues/29, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJILKHNZJFLIHFUCRSOVYW3TRIMDDANCNFSM46EQIMBA .

--

Brian Seltzer Field Technical Director - East +1(484)356-3428 @.***

--

Brian Seltzer Field Technical Director - East +1(484)356-3428 @.***

SerErris commented 3 years ago

So your version works better for older releases. Should that get changed at some point in time to current versions? It is in the 6.5.1 API set (not checked any older version).

bseltz-cohesity commented 3 years ago

Yeah I could update it maybe after 631 goes EOL. It’s a pain to test because if it works then you have to add the node back in before testing again πŸ™„

On Sat, Jun 5, 2021 at 9:22 AM Christoph Linden @.***> wrote:

So your version works better for older releases. Should that get changed at some point in time to current versions? It is in the 6.5.1 API set (not checked any older version).

β€” You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/bseltz-cohesity/scripts/issues/29#issuecomment-855239698, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJILKHM7VCGEQSLYHW4P6JLTRIQI3ANCNFSM46EQIMBA .

--

Brian Seltzer Field Technical Director - East +1(484)356-3428 @.***