bsermons / flycheck-elm

Flycheck support for the elm language
GNU General Public License v3.0
18 stars 8 forks source link

Use flycheck's new :default-directory option to handle projects with subdirs #10

Closed purcell closed 8 years ago

purcell commented 8 years ago

This enables the checker if and only if an existing elm-package.json can be found, and runs elm-make from the directory of that file.

The previous behaviour of allowing elm-make to implicitly create elm-package.json in the current directory - which could cause the checker initialisation to hang - is also therefore avoided. Initial invocation of elm-make is best carried out interactively, rather than implicitly.

Fixes #3, but is pending the next flycheck release: 0.29. This code works with the current MELPA snapshot package though, so you might consider committing this already, then not tagging a new stable version of flycheck-elm until the next flycheck stable release has been made.

bsermons commented 8 years ago

Thanks for this! I had been watching that flycheck PR for a while so glad it finally landed. As long as it works with MELPA that is good enough for me.