search

bsermons / flycheck-elm

Flycheck support for the elm language
GNU General Public License v3.0
18 stars 8 forks source link

Elm 0.19 compatibility #17

Closed purcell closed 5 years ago

purcell commented 5 years ago

I started tinkering with this, and figured I'd share what I have in case someone else wants to pick it up or has feedback.

The changes so far are sufficient to correctly invoke "elm make" if the user has customized flycheck-elm-executable to "elm". This is not sufficient to get any errors displayed via flycheck: the key issue seems to be that the JSON output of elm make has changed substantially, so converting the new-style JSON into flycheck errors requires code that has yet to be written.

purcell commented 5 years ago

Right, I think I have Elm 0.19 compilation errors working now. Would someone like to test this out?

@bsermons - you don't seem very active on github these days, so if it would be helpful to you, feel free to add me as a committer here and I can help to marshall changes like this into the repo. Alternatively, maybe it would make sense to transfer this repo to the flycheck org, of which I am a member.

bsermons commented 5 years ago

Thanks for taking the initiative here @purcell and you are correct on your assessment :) I'm willing to go either route as I don't use Elm much even when I do find some spare time nowadays. I'll go ahead and make you a contributor and if flycheck org wants to take this under its umbrella then we can transfer it later once that is confirmed.

purcell commented 5 years ago

Thanks Brian, makes sense. Will go ahead and merge this now.