search

bsf15 / bsf15_repo

This is my repo for my personal website.
2 stars 0 forks source link

HTML Feedback #2

Open RJP43 opened 7 years ago

RJP43 commented 7 years ago

@bsf15

The following are @ahunker 's and my comments on your submission for HTML Exercise 1:

We are really happy to see that you have successfully added an index page to your personal PSC space and pushed it to this GitHub repo. Well done! We like the way your site looks; the colors you chose are visually appealing and accentuate the colors in your image. We also like how you've set up your page; it allows one's eye to just gradually go down the page. One suggestion, however, would be to consider keeping the text on your page (after the About Me header) left aligned. It can be difficult to read lines of text on the screen especially when they are center aligned. As I mentioned in class you could still have the block of text centered on the screen, but have the text itself left-aligned. Nice job with adding an image and several external links; your next step would be to create some internal links that lead to other pages associated with your personal website (perhaps a page sharing some of your writing). Also, we are impressed you chose to use the HTML elements that create an unordered list. We also like that you've experimented with using elements to style the text, such as <strong>. Pre-styled HTML elements can be very handy as you have experimented here with your variety of HTML elements.

The next big step for you to complete HTML Exercise 2 will be to write a Server Side Include. This can be confusing the first time you write one on your own, but just be sure to read through the instructions on the assignment and our SSI tutorial. Remember, if you get stuck comment on the DHClass-Hub. Trust me if you are confused so are others!

Great work so far; you can find your grade for HTML Exercise 1 on Courseweb.

RJP43 commented 7 years ago

@bsf15

The following are @jonhoranic and my comments on your submission for HTML Exercise 2:

The HTML code on each of your pages is well structured and consistent across your numerous internal pages. Your CSS is well crafted and is accomplishing a lot in creating an appealing visual structuring of your site; however, we think you should experiment further with font sizes (as your text is rather small making it slightly difficult to read), image sizing (there is a lot of unused space in the middle of your page in comparison to the full-page spanning of the text div) , and general spacing (i.e. padding and margins) of your images and text across your entire site. Of course, there are always little tweaks that can be made (like perhaps see if adding a colored border on your index image helps make it pop more). We do really like your color choices and what you have decided to present to viewers on your site (as in your writing and digital work) because it leaves a lot of room for you to continue building on this space well after this course is completed.

Taking a look at your server permissions: bsf15_permissions We noticed you do not have our recommended permissions set. As you continue to work and build your site it will be important that you change your file permissions so ALL of your files give

  1. you (owner) read, write, execute permissions
  2. group (us other Newtonians) read and execute permissions
  3. others (the world viewing your site) read and execute permissions

We are happy to see you have incorporated an SSI onto your page; however, it looks like your SSI is only being used on your index page. The links all work to direct site visitors to the correct pages, but you might go back and experiment with having an SSI that you are using across multiple pages. Perhaps turn your "Return to Main Page" link that is on all of your other pages (besides your index page) into an SSI that way in case you ever have to change anything with that link you will only need to change it once in the file being called on in the SSI instead of having to go to every page with that link and making the adjustment. We see this isn't really a huge concern for such a small site but you can imagine the usefulness of SSIs when working with a site that has even more pages.

Overall, we think you have a pretty clear understanding of how to manipulate your HTML and CSS to create a clean and logical personal website. We encourage you to continue messing with this site throughout the semester and after this course ends to improve upon what you have accomplished here for these assignments.

Great work; you can view your grade for HTML Exercise 2 on Courseweb.