bshaffer / sfHadoriThemePlugin

symfony admin generator with a beautiful theme and clean generated code.
MIT License
21 stars 6 forks source link

Misc bugfixes #17

Closed roldan closed 13 years ago

bshaffer commented 13 years ago

Looks great! Thanks Matías!

Pull request applied.

roldan commented 13 years ago

Great! One thing that still pendent. The images path in css... What do you think to use?

/sfHadoriThemePlugin/images

instead of

../images

I have my backend app in /admin/ and the path is incorrect

bshaffer commented 13 years ago

Matias, The ../ is relative, so it should work with an /admin prefix. Your version, /sfHadoriThemePlugin wouldn't work, as the path would need to be /admin/sfHadoriThemePlugin in your project. You've made it absolute. The relative ../ handles this.

It shouldn't be broken at all. The relative path is incorrect. Unless I'm missing something. If anything, /sfHadoriThemePlugin would be the broken one!

roldan commented 13 years ago

Brent, just to clarify, i don't have a /admin subdirectory under by web/ dir (document root). I redirect every url prefixed with "admin" to my backend.php front-controller. If i use "../" work, but only using backend_dev.php as front-controller. If i use "admin/" (backend.php front-controller) i can't do work. In contrast, if i use /sfHadoriThemePlugin/images i do work in both "admin/" and "backend_dev.php".

this is my .htacces file:

RewriteCond %{REQUEST_URI} ^/admin/?
RewriteRule ^(.*)$ backend.php [QSA,L]

If I use /, perhaps I am not referring to the document root (which would be my web / dir)? Then it is correct because there is a symlink to / from sfHadoriThemePlugin ...

bshaffer commented 13 years ago

Yeah it looks like you're essentially writing urls such as /admin/sfHadoriThemePlugin/css/theme.css to backend.php, which of course will not work. This is not a problem with the plugin, but a problem with your rewrite rule.

I cannot make this change because the /sfHadoriThemePlugin path would be invalid for someone who's site lived at mydomain.com/symfony/ instead of mydomain.com. In your case, I would suggest using a subdomain (http://admin.mydomain.com) instead of a RewriteRule

roldan commented 13 years ago

Ok, then I'll use a subdomain. Thanks, Matías