search

bshaffer / sfHadoriThemePlugin

symfony admin generator with a beautiful theme and clean generated code.
MIT License
21 stars 6 forks source link

I18N #6

Closed roldan closed 13 years ago

roldan commented 13 years ago

Hello, I can activate this plugin I18N? I see that printed texts are hardcoded and not through the "__". Could you help me? Thanks! Matías

bshaffer commented 13 years ago

Matias, you can override some of the methods in the generator to accomplish this. I'll look into adding this in core, it shouldn't be too hard. I've been planning to add it, but haven't had time.

The idea will be to alter the sfHadoriThemeGenerator class to output PHP blocks with the __() function call if i18n is enabled.

I purposely took out i18n to start, as this is not required by everyone and adds a lot of complexity. This should be an optional feature, and not included in everything, as it is in the default admin generator.

Thanks for logging this issue! I'll try to get to this soon.

bshaffer commented 13 years ago

i18n support has been added. Please check out the newest release of sfHadoriThemePlugin.

To upgrade, be sure to:

  1. change sfHadoriAdminRouteCollection to sfHadoriRouteCollection
  2. change sfHadoriThemeGenerator to sfHadoriGenerator