bshall / acoustic-model

Acoustic models for: A Comparison of Discrete and Soft Speech Units for Improved Voice Conversion
https://bshall.github.io/soft-vc/
MIT License
100 stars 24 forks source link

fixed checkpointing interval #8

Closed qGentry closed 1 year ago

qGentry commented 2 years ago

Hello! I've found bug with checkpointing in your code which leads to that only best checkpoints is getting saved. This happens because if CHECKPOINT_INTERVAL = VALIDATION_INTERVAL (default case), then if global_step % VALIDATION_INTERVAL == 0 and if global_step % CHECKPOINT_INTERVAL never evaluates to True. This pull request fixes this.