search

bshall / knn-vc

Voice Conversion With Just Nearest Neighbors
https://bshall.github.io/knn-vc/
Other
431 stars 64 forks source link

add functions to generate SPEAKER_INFORMATION_WEIGHTS list #21

Closed KeiKinn closed 11 months ago

RF5 commented 11 months ago

Hi @KeiKinn , thanks for the PR.

One question where I am a little confused: what exactly is the reason for redefining a constant variable into a function which just produces that constant variable? i.e. what is the purpose of this PR?

KeiKinn commented 11 months ago

Hi, Thank you for your reply and exciting work.

This flexibility can be beneficial in scenarios where you need to test various configurations for different layers, even you could merge different layers' embeddings. It will save time and effort compared to having to modify the layer list and layer index each time. But feel free to abort this PR if you think it's not helpful to your code :)

Hi @KeiKinn , thanks for the PR.

One question where I am a little confused: what exactly is the reason for redefining a constant variable into a function which just produces that constant variable? i.e. what is the purpose of this PR?

RF5 commented 11 months ago

Ok I see. It might save a character or two of typing. Merged!