bshepherdson / foam-migration-test

0 stars 0 forks source link

Code review request #114

Closed bshepherdson closed 10 years ago

bshepherdson commented 10 years ago

From arthur...@google.com on December 02, 2013 17:54:45

Branch name: Purpose of code changes on this branch: When reviewing my code changes, please focus on: After the review, I'll merge this branch into: /trunk

Original issue: http://code.google.com/p/foam-framework/issues/detail?id=114

bshepherdson commented 10 years ago

From arthur...@google.com on December 02, 2013 14:55:46

Branch name: array_mreduce Purpose: resolve Array.prototype.reduce naming conflict. This is blocking our move to integrate with blaze.

bshepherdson commented 10 years ago

From k...@chromium.org on December 02, 2013 15:59:57

All of the reduce() methods in mlang.js will also need to be renamed to be consistent with this change.

Actually, we already have the reduceI method for reduce-imperative, so a better name for 'mreduce' would be reduceF for reduce-functional. On third thought, that naming is a bit odd, so maybe: fReduce and iReduce would be better.

bshepherdson commented 10 years ago

From arthur...@google.com on December 02, 2013 19:04:24

That could be a different change right? The reduce methods in mlang.js belongs to Model, not Array.

So can we get this in first and carry on to unblock dpapad@?

bshepherdson commented 10 years ago

From k...@chromium.org on December 03, 2013 08:29:32

LGTM, I'll update mlang.js in a different CL.

bshepherdson commented 10 years ago

From k...@chromium.org on December 04, 2013 11:51:27

Status: Done