made some changes - Githubissues

qsysd commented 2 months ago

Hello, NPS on Windows Server 2022 and SQL Server is 2017. I had to make some changes in order to work. NPS kept sending a huge number as NAS_Port so sp_xml_preparedocument was failing and there was an event 4403 in Windows event log: NPS cannot log accounting information in the primary data store (ssql). Because of this, NPS is now logging accounting information in the secondary data store. Error information: 0x80040e57.

nps_accounting_table :

corrected obvious semantic mistake at [timestamp] [datetime2](3) NOT NULL
changed NAS_Port from int to bigint [NAS_Port] [bigint] NULL,
removed OPTIMIZE_FOR_SEQUENTIAL_KEY = ON, (not in SQL 2017)

nps_sp_reportEvent:

changed NAS_Port bigint './NAS-Port',

JasonEverling commented 2 months ago

Do you want to submit the changes or want me to make them? You can send over a pull request

qsysd commented 2 months ago

I'm sorry I can't, I don't use git at the moment.

bshp / nps_accounting

made some changes #2