search

bshyong / ga-bitbot

Automatically exported from code.google.com/p/ga-bitbot
GNU General Public License v3.0
1 stars 0 forks source link

Minor source code issues #57

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I couldn't thoroughly test all of the issues I mention here but they seems to 
be bugs

* http://code.google.com/p/ga-bitbot/source/browse/gene_server.py#202 it has to 
be array creation here so you can append in next line
* http://code.google.com/p/ga-bitbot/source/browse/bct_active.py#577 I think 
this is an indentation mismatch after tabs covert

Original issue reported on code.google.com by enikesha on 19 Feb 2013 at 6:10

GoogleCodeExporter commented 9 years ago 
* http://code.google.com/p/ga-bitbot/source/browse/config/gene_def.json#58 -- 
With offset 1 rsi is always enabled since it's tested in code like `if 
self.rsi_enabled > 0`

Original comment by enikesha on 19 Feb 2013 at 5:40

GoogleCodeExporter commented 9 years ago 
Confirmed bug in gene_server.py - added brackets around the statement to make 
the variable 'r' a list.

Confirmed bug in bct* also. Accumulation in variable 'l' should be outside the 
if condition.

Regarding gene_def.json - I added the offset for testing and yes it forces RSI 
to always to be enabled. gene_def files are meant to be modified by end users - 
the one on the repo is for testing and to provide an example of the file 
format.

Original comment by brian.mo...@gmail.com on 23 Feb 2013 at 2:53

GoogleCodeExporter commented 9 years ago 
After looking into the gene_server issue more closely I realized the fix went 
in the wrong direction in that the variable should not have been a list. There 
was also another issue in that it was sorting on the score when it should have 
been sorting for the most recent.

http://code.google.com/p/ga-bitbot/source/browse/gene_server.py#200

Original comment by brian.mo...@gmail.com on 27 Feb 2013 at 4:50