bsidelinger912 / shiitake

React Line clamp that won't get you fired
MIT License
101 stars 22 forks source link

Use ellipsis instead of three dots #12

Closed sonicdoe closed 7 years ago

bsidelinger912 commented 7 years ago

Hey @sonicdoe, thanks for the PR. I actually was just recently working on a new feature where you can pass an additional prop that would allow for customization of the overflow indication. You can see the diff here: https://github.com/bsidelinger912/shiitake/pull/13. It was definitely a good call to use a real ellipsis though, so I made the default a real ellipsis, but I used the unicode character. I'll close this for now because I don't think it's relevant anymore.