search

bsidelinger912 / shiitake

React Line clamp that won't get you fired
MIT License
100 stars 22 forks source link

Closes #15 - Prevent NPM warning over peerDependency for React 16 #16

Closed lostthetrail closed 6 years ago

lostthetrail commented 6 years ago

@bsidelinger912 mind taking a look? Closes #15

bsidelinger912 commented 6 years ago

this looks great, I'll test ASAP, then merge and publish. Thanks!

lostthetrail commented 6 years ago

@bsidelinger912 Thanks!

bsidelinger912 commented 6 years ago

@lostthetrail I just grabbed the react dependency as while it's unlikely, Shiitake can be used without react DOM. I just published v2.2.1 and tested using yarn with React 16 (and 15), and it looks good to me. Please let me know when you have a chance to try it.

lostthetrail commented 6 years ago

Looks to be working with your 2.2.1 changes. Cheers!