search

bsidelinger912 / shiitake

React Line clamp that won't get you fired
MIT License
100 stars 22 forks source link

add custom params #29

Closed StipJey closed 4 years ago

StipJey commented 5 years ago

For example, I would like to add the "title" property

bsidelinger912 commented 5 years ago

@StipJey this makes total sense, I'll work on some support. Just to clarify though, you want to add title to the tag we wrap around the target, correct? This would essentially be a tooltip for screen readers and such I'd imagine. If you actually want it to be applied to the tooltip itself, let me know as that's a different use case altogether (which is ok too, but want to be clear).

bsidelinger912 commented 4 years ago

I believe this is addressed now with https://github.com/bsidelinger912/shiitake/releases/tag/v3.0.0.