search

bsidelinger912 / shiitake

React Line clamp that won't get you fired
MIT License
100 stars 22 forks source link

Remove 'componentWillReceiveProps' for React 17 #32

Closed zioth closed 4 years ago

zioth commented 5 years ago

componentWillReceiveProps and the other will lifecycle events are deprecated, and support will be removed soon. Please either remove the need for these events, or switch to the UNSAFE_ versions.

Thanks!

bsidelinger912 commented 5 years ago

Will do, been meaning to do this, thanks for the reminder @zioth

zioth commented 5 years ago

Thanks!

bsidelinger912 commented 4 years ago

@zioth looking closer this is best done by switching to hooks and cleaning up some of the old logic. I'm working on that and plan on addressing this with a MV that requires react 16.8+ as a peer dependency. I'll let you know when it's out.

zioth commented 4 years ago

Sounds great. Thanks!

bsidelinger912 commented 4 years ago

Finally got this done @zioth, see: https://github.com/bsidelinger912/shiitake/releases/tag/v3.0.0.

zioth commented 4 years ago

Thank you! I look forward to trying out the new version.