search

bsidelinger912 / shiitake

React Line clamp that won't get you fired
MIT License
100 stars 22 forks source link

Can be "a" in the tag whitelist? #34

Closed ycanales closed 4 years ago

ycanales commented 4 years ago

Would the truncation work? Thanks!

bsidelinger912 commented 4 years ago

hey @ycanales the only issue I see with this is that I don't pass arbitrary props into the wrapper tag, so you wouldn't be able to add an href. I do pass events in though so maybe that's all your needing? I'm considering passing more props along, but there's some potential drawbacks I'm thinking about how to mitigate.

bsidelinger912 commented 4 years ago

@ycanales I just added in v3 as well as a new prop called "attributes" where you can pass additional attributes like "href". See here for details: https://github.com/bsidelinger912/shiitake/releases/tag/v3.0.0.

ycanales commented 4 years ago

@bsidelinger912 thanks a lot!