bsides / horizoverlay

A simple horizontal damage meter overlay for Final Fantasy XIV. It currently shows player dps, damage %, hps, max hit, encounter duration and total dps. It's super configurable! It supports English, Portuguese, Chinese (S/T) and French.
Apache License 2.0
127 stars 48 forks source link

Requesting visual for Percentile Plugin #63

Open Sapphiratelaemara opened 6 years ago

Sapphiratelaemara commented 6 years ago

Would be nice if we could get to see the number from https://github.com/Liquidize/FFXIV_PercentilePlugin on the overlay so making a humble request <3

bsides commented 6 years ago

Hi @Sapphiratelaemara!

Looks like a very nice addition indeed. As I'm not playing the game I couldn't implement it right now but I'll as for help and see what can be done.

Thanks for the input! <3

unfaiyted commented 6 years ago

@Sapphiratelaemara I'll go ahead and fork this and take a stab at it.

unfaiyted commented 6 years ago

If you want to test it out I published it here using the settings @bsides setup and such. I think it is working but I'm going to test it more. Would you like me to create a pull request for this?

bsides commented 6 years ago

Hi @unfaiyted!

Sure, you can send a PR for it, it would be much appreciated. The bad news though is that I cannot test it right now. I'm not playing the game right now, the subscription is becoming too expensive in my country unfortunately. I'm planning on coming back in the next month or december though. Until then I'd suggest you use your version (or fork mine like you probably did) until I can release a proper one.

Thanks for your efforts again. Send you PR regardless so we can comment on it.

bsides commented 5 years ago

Since I wasn't playing until now I couldn't test it. Sorry for it =/

I'm going to attempt to bring it on with the next version of the overlay. If that take too much time, I'll try to push this through.

Thanks again for the help!