Closed Stephan202 closed 1 year ago
@bsideup would you have time to review this small PR?
I'd like to introduce this library in a project that (a.o.) builds against JDK 20 (see PicnicSupermarket/error-prone-support#603), but without these changes our build fails.
It would help us enormously if this PR could be reviewed and merged 😄. Could you take a look at this? @bsideup
At this point, it might be better to switch to https://github.com/RaphiMC/JavaDowngrader
Tnx for sharing @NebelNidas! On cursory inspection of that project, it doesn't appear to provide a javac
plugin, meaning that it can't "simply" be added to the annotationProcessorPaths
of the maven-compiler-plugin
. That's probably fixable, though.
@bsideup I'm sure you're super busy; if there's anything else we can do to get this merged/released (perhaps deferring review to another dev you trust with this task?), do let us know. :heart:
Rebased and updated the PR (including the PR description). It turns out that JDK 21 compatibility also required upgrading Byte Buddy, so I added that to the change set. As best as I can tell this makes the plugin compatible with JDK 20 and JDK 21.
Hi everyone! I apologize for missing this PR (thank you @asolntsev for the ping!). I just merged it and will release a new version ASAP.
@Stephan202 thank you for your contribution (and consistency!)
Thanks for releasing version 1.0.1, @bsideup! I know Maven Central syncing can take a few hours, and that therefore release may not yet be visible here, but a direct download also yields an HTTP 404 response. Could it be that the artifacts have have yet to be published?
Hey @bsideup! I see that the artifact is still not on Maven Central. Can you please have a look? :pray:
^ @sergeykad just filed a separate issue for this: #182. (Tnx!)
This PR aims to resolve the following error when building with JDK 20 (which I hit while working on PicnicSupermarket/error-prone-support#603):
This PR also resolves the following error when using JDK 21:
I hope that this change matches the spirit of what
CheckSourceLevelAdvice
is meant to do :crossed_fingers:.Suggested commit message: