bsileo / hubitat_poolcontroller

Integration from a SmartThings or Hubitat hub to nodejs_poolcontroller
MIT License
8 stars 5 forks source link

UI Improvements #10

Closed GitHubGoody closed 4 years ago

GitHubGoody commented 4 years ago

@bsileo Here is a screenshot of the ST UI on my iPhone 11 Pro.

20200710_131016000_iOS

Here are my issues with it:

Missing the AuxX circuit Missing the Spa circuit Are the top icons supposed to be round (not oval)? What is the 72 indicating? The font is too small What are all of the -- supposed to indicate? How can I tell if the pool or spa temp is current or last read?

bsileo commented 4 years ago

We don't have any control over round vs. oval icons - that's SmartThings being lame. Same for the Font size - not in my control. 72 is the Air Temp The "--" are just supposed to be blank tiles. I guess on iOS is puts those dashes in. On Android these show up as blank. ST makes the UI very hard to configure dynamically for different pool setups.

Here is everything that is added, but if any of these children do not exist they are skipped in ST. Note that you can also just go to the individual devices and not use the main "Pool" device with all this clutter on it.

"airTemp","solarTemp","dummy","refresh",
                "setPoint-1","heatMode-1","temperature-1", "dummy-b-1", "dummy-b-1", "dummy-b-1",
                "setPoint-2","heatMode-2","temperature-2", "dummy-b-2", "dummy-b-2", "dummy-b-2",

                "saltLevel-1","saltRequired-1","superClorinate-1","superChlorHours-1","currentOutput-1","poolSetpoint-1","spaSetPoint-1","chlorStatus-1",
                "saltLevel-2","saltRequired-2","superClorinate-2","superChlorHours-2","currentOutput-2","poolSetpoint-2","spaSetPoint-2","chlorStatus-2",
                "Circuit 2 Switch","Circuit 3 Switch","Circuit 4 Switch","Circuit 5 Switch","Circuit 6 Switch","Circuit 7 Switch",
                "Circuit 8 Switch",
                "feature11","feature12","feature13","feature14","feature15","feature16","feature17","feature18"

[Aside...several items in the list here for why I moved to Hubitat!]

bsileo commented 4 years ago

Here is a view on Android:

Screenshot_20200711-091020_SmartThings

bsileo commented 4 years ago

Also, you can technically edit / change this layout. Just edit what is included in your local copy of the Pool-Controller.groovy on your St hub in the details section

GitHubGoody commented 4 years ago

Ok, thanks. The 72 would be solartemp then, but I don’t have solar. Guess I can just delete that one.

GitHubGoody commented 4 years ago

For the groovy edits, I tried to change it to this

        details (
            "airTemp","refresh",
            "setPoint-1","heatMode-1","temperature-1"
            "setPoint-2","heatMode-2","temperature-2"
            "saltLevel-1","saltRequired-1","currentOutput-1","poolSetpoint-1","spaSetPoint-1","chlorStatus-1",
            "Circuit 5 Switch","Circuit 6 Switch","Circuit 2 Switch","Circuit 3 Switch","Circuit 4 Switch","Circuit 7 Switch",
            "Circuit 8 Switch",
            "feature11","feature12","feature13","feature14","feature15","feature16","feature17","feature18"
            )

...but got this when I tried to save...

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
script_dth_metadata_cd1ac6b5_7055_404d_8113_0dc21559855c: 123: expecting ')', found 'setPoint-2' @ line 123, column 17.
"setPoint-2","heatMode-2","temperature-2"
^

1 error

What did I mess up? Also, what do I need to put to see the AuxX circuit (e.g. "Circuit Aux")?

bsileo commented 4 years ago

I think you are missing a comma after "temperature-1"

I am not sure what the Circuit Aux is -Do you have this on the WebClient for NJPC? I have to understand that as I do not think it is available in ST/Hubitat at this time.

GitHubGoody commented 4 years ago

Thanks. Yes, my Spillway is configured to the AuxX circuit which allows me to use the Solar button on the ET4 hard panel in place of the not-configured Solar.

I figured out that the air and solar temp tiles were ovals because you have them set to 2 wide by 1 tall. I changed all tiles to 2 x 2 and here is what it looks like. 20200712_053219000_iOS

bsileo commented 4 years ago

Thanks for the update on the icon appearance - a difference between Android and iOS I suppose. In general, there is no way to create intelligence in the way the UI is built in SmartThings, so I took the approach of creating all the child devices so each user would have control of things, and attempted this general UI. The path you have taken, adjusting it to your own needs is really the only way to get it specific to a given user that I know.

bsileo commented 4 years ago

I do not have solar or this configuration on my system. Are you able to control the AuxX button from the webClient UI in the PoolController? I need to get some details on what is happening when that is pressed so I can see about adding it to the SmartTHings side.

Perhaps send me the output from: http://server1:4200/state/all http://server1:4200/config/all

Trying to understand where I would detect that setup and its current state.

bsileo commented 4 years ago

I just found this in my /config/all

{
"id": 20,
"name": "AUX EXTRA",
"nameId": 93,
"type": 0,
"isActive": true,
"freeze": false,
"showInFeatures": true,
"eggTimer": 0,
"macro": false
}

Is this the same Feature you are seeing connected to the Solar button?

GitHubGoody commented 4 years ago

Yes. Also, I do have a child device for it (Spillway) in ST, and yes it’s also available on the web client.


From: Brad Sileo notifications@github.com Sent: Sunday, July 12, 2020 6:12:25 AM To: bsileo/hubitat_poolcontroller hubitat_poolcontroller@noreply.github.com Cc: GoodyGizmos afgoody@gmail.com; Author author@noreply.github.com Subject: Re: [bsileo/hubitat_poolcontroller] UI Improvements (#10)

I just found this in my /config/all

{ "id": 20, "name": "AUX EXTRA", "nameId": 93, "type": 0, "isActive": true, "freeze": false, "showInFeatures": true, "eggTimer": 0, "macro": false }

Is this the same Feature you are seeing connected to the Solar button?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/bsileo/hubitat_poolcontroller/issues/10#issuecomment-657220069, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALAYAYMBLSGDBV4KPXV2CF3R3GZDTANCNFSM4OXEO3FA.

bsileo commented 4 years ago

OK is that Child working to control it in ST? If so then we are just missing it on the main PoolController device tiles?

GitHubGoody commented 4 years ago

Yes (just verified)

C4199336-3A59-4A2F-B22F-35A6A6366E03

bsileo commented 4 years ago

Can you look at that in https://graph.api.smartthings.com/device/list and tell me what the 'Device Network ID' is for the Pool (Spillway) device?

BTW - you can feel free to edit and rename these - only the Device Network ID matters to the code keeping updates flowing. I see you already figured out you can change the icons on them!

GitHubGoody commented 4 years ago

B827EB548DF6-feature-20

I tried to insert "feature20", but it didn't work

Also, I realized that I missed one of your requests above. Here are the state and config results. State.txt Config.txt

bsileo commented 4 years ago

I just pushed an update to add support for going up to ID 20 for features. I had them going from 11-20.

Code

GitHubGoody commented 4 years ago

Thanks. I updated from repo, set all the tiles back to 2x2 and then set up the tiles to this:

        details (
            "airTemp","Circuit 3 Switch","Circuit 4 Switch",
            "temperature-1","setPoint-1","heatMode-1",
            "temperature-2","setPoint-2","heatMode-2",
            "saltLevel-1","currentOutput-1","poolSetpoint-1",
            "Circuit 2 Switch","feature11","feature20",
            "Circuit 6 Switch","Circuit 1 Switch","refresh"
            )

It looks good. 20200714_052608000_iOS 20200714_052613000_iOS

bsileo commented 4 years ago

Sweet glad it is working for you!

On Tue, Jul 14, 2020, 1:28 AM GoodyGizmos notifications@github.com wrote:

Thanks. I updated from repo, set all the tiles back to 2x2 and then set up the tiles to this:

    details (
        "airTemp","Circuit 3 Switch","Circuit 4 Switch",
        "temperature-1","setPoint-1","heatMode-1",
        "temperature-2","setPoint-2","heatMode-2",
        "saltLevel-1","currentOutput-1","poolSetpoint-1",
        "Circuit 2 Switch","feature11","feature20",
        "Circuit 6 Switch","Circuit 1 Switch","refresh"
        )

It looks good. [image: 20200714_052608000_iOS] https://user-images.githubusercontent.com/46235745/87387707-24001300-c558-11ea-9681-e9fb19504990.png [image: 20200714_052613000_iOS] https://user-images.githubusercontent.com/46235745/87387710-2498a980-c558-11ea-8c99-4e9ddc227871.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bsileo/hubitat_poolcontroller/issues/10#issuecomment-657975337, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOVFMBAAE7ONGQWZUWZ23LR3PUILANCNFSM4OXEO3FA .