bsimser / Inventory-Pro

https://devdog.io
MIT License
2 stars 0 forks source link

No Virtual Methods #269

Closed bsimser closed 5 years ago

bsimser commented 5 years ago

Original report by Anonymous.


https://inventory-pro-docs.readthedocs.io/en/latest/API/Serialization/

It says: "This object is completely marked virtual...".

The first thing is that C# has no notion of a virtual class. It's imprecise wording like this that makes things so difficult to understand. Secondly, there are no virtual methods in this class to override.

bsimser commented 5 years ago

Original comment by Joris Huijbregts (Bitbucket: jjahuijbregts, ).


Not sure what happened there. I've marked the methods virtual and will get those included in the next update cycle. For now, feel free to mark them virtual in the base class.

I've also updated the documentation to more clearly explain that all methods are marked as virtual and improved the code example.