Open bskinn opened 4 years ago
Regular Python exceptions are explicitly raised at various spots in the codebase.
Better to refactor these to (possibly new) subclasses of SphobjinvError.
SphobjinvError
CountError
ValueError
contract
expand
True
Make sure to remove any per-file flake8 error ignores for cmdline.py once the exception handling is (presumably) de-generalized.
cmdline.py
Regular Python exceptions are explicitly raised at various spots in the codebase.
Better to refactor these to (possibly new) subclasses of
SphobjinvError
.CountError
" instead ofValueError
orValueError
ValueError
contract
andexpand
bothTrue
error, instead ofValueError
Make sure to remove any per-file flake8 error ignores for
cmdline.py
once the exception handling is (presumably) de-generalized.