search

bskinn / sphobjinv

Toolkit for manipulation and inspection of Sphinx objects.inv files
https://sphobjinv.readthedocs.io
MIT License
78 stars 9 forks source link

Rework test suite to pull remote inventories from current branch on Github #228

Closed bskinn closed 2 years ago

bskinn commented 2 years ago

As it was configured previously, the test suite would always look on main for the remote objects_xyz.inv files to pull from Github.

Now, it will always pull from the current branch (relative to what's checked out locally, or the branch a given commit is on, on CI), which should simplify working with development branches where it's necessary to add a new objects_xyz.inv to tests/resource (as in #226), as the file will not need to be merged into main before it can be picked up by the work in the development branch.

bskinn commented 2 years ago

Nope nope. Going to be a massive headache getting the code to pull this from the right place during PR CI runs. It would have to come from the fork's development branch, and it looks like there may not even be a particularly great way of getting the correct info. This suggests there might be a way, but it might only work if the Azure and Github usernames are identical, etc.

Annoying to have to cope with adding the new inventories directly to main, but it definitely is the least painful option.