search

bslatkin / dpxdt

Make continuous deployment safe by comparing before and after webpage screenshots for each release. Depicted shows when any visual, perceptual differences are found. This is the ultimate, automated end-to-end test.
https://dpxdt-test.appspot.com
Apache License 2.0
1.44k stars 124 forks source link

Webfont's inconsistent rendering causing false negatives #108

Closed pitchandtone closed 9 years ago

pitchandtone commented 9 years ago

screen shot 2014-10-06 at 3 57 48 pm

Same content, but one where it wraps and one where it doesn't. Same screensize, same URL.

bslatkin commented 9 years ago

Definitely a problem. The core issue here is it's an old, old version of WebKit. I hear that Phantom JS 2.0 will fix webfonts completely. I'm not sure if we should try to address this somehow or just wait for that to be released?

https://github.com/ariya/phantomjs/wiki/PhantomJS-2

pitchandtone commented 9 years ago

Can webfonts be disabled until this?

Sent from my iPhone

On 6/10/2014, at 4:02 pm, Brett Slatkin notifications@github.com wrote:

Definitely a problem. The core issue here is it's an old, old version of WebKit. I hear that Phantom JS 2.0 will fix webfonts completely. I'm not sure if we should try to address this somehow or just wait for that to be released?

https://github.com/ariya/phantomjs/wiki/PhantomJS-2

— Reply to this email directly or view it on GitHub.

bslatkin commented 9 years ago

I'm going to merge this with #132