add --ssl-protocol=TLS1 to phantomjs invocation

bslatkin / dpxdt

Make continuous deployment safe by comparing before and after webpage screenshots for each release. Depicted shows when any visual, perceptual differences are found. This is the ultimate, automated end-to-end test.

https://dpxdt-test.appspot.com

Apache License 2.0

1.44k stars 124 forks source link

add --ssl-protocol=TLS1 to phantomjs invocation #113

Closed nicks closed 10 years ago

nicks commented 10 years ago

Without this change, sites over SSL don't work for me. I don't totally understand why this fixes my problem though. I guess certain SSL/TLS protocols in phantomjs are buggy, and this forces TLS1?

Alternatively, I'd be happy to add a flag that lets you pass custom flags to phantom on server start.

bslatkin commented 10 years ago

Seems good to me. Thanks for the patch!