search

bslatkin / dpxdt

Make continuous deployment safe by comparing before and after webpage screenshots for each release. Depicted shows when any visual, perceptual differences are found. This is the ultimate, automated end-to-end test.
https://dpxdt-test.appspot.com
Apache License 2.0
1.44k stars 124 forks source link

site_diff: Relative URLs with <base> tag not supported #127

Open hlubek opened 9 years ago

hlubek commented 9 years ago

Some websites use a <base href="http://www.example.com/" /> tag to specify the base for relative URLs. The site_diff script currently generates wrong URLs in these cases (the relative path is appended to the current URL of the page).

bslatkin commented 9 years ago

Good catch! That's a tricky one. What's your expectation of that behavior?

I figure the way it would have to work is to set the prefix here:

https://github.com/bslatkin/dpxdt/blob/master/dpxdt/tools/site_diff.py#L141