search

bslatkin / dpxdt

Make continuous deployment safe by comparing before and after webpage screenshots for each release. Depicted shows when any visual, perceptual differences are found. This is the ultimate, automated end-to-end test.
https://dpxdt-test.appspot.com
Apache License 2.0
1.44k stars 124 forks source link

Update to PhantomJS 2 #132

Closed danvk closed 9 years ago

danvk commented 9 years ago

It's here! http://phantomjs.org/release-2.0.html

This update includes several years' worth of browser improvements, including support for things like web fonts and styling of UI widgets.

danvk commented 9 years ago

Unclear what "update" means here since dpxdt doesn't include an explicit dependency on Phantom. Maybe just "verify that it works with PhantomJS2"?

bslatkin commented 9 years ago

Yeah I think that's all it is. :)

pitchandtone commented 9 years ago

Subscribe

danvk commented 9 years ago

I just ran site_diff.py w/ a local server on my Mac using PhantomJS2. It made a mysterious Failed after max attempts: CaptureFailedError: Sent SIGKILL to item=dpxdt.client.capture_worker.CaptureWorkflow error which I think had something to do with TypeKit go away.

@bslatkin unless you have any objections, this is safe to close!

bslatkin commented 9 years ago

Awesome. Do we need to update the instructions to say install PhantomJS 2? Or are we good? I've got some general changes to the README coming in my virtual_env branch so I can mention we're using Phantom 2 in there.

danvk commented 9 years ago

The version I linked to is a fork that runs on OS X Yosemite. So long as users can get a copy of phantomjs2 that runs on their machine, dpxdt should just work.