Do not throw NotReadyError for HTTP redirects

bslatkin / dpxdt

Make continuous deployment safe by comparing before and after webpage screenshots for each release. Depicted shows when any visual, perceptual differences are found. This is the ultimate, automated end-to-end test.

https://dpxdt-test.appspot.com

Apache License 2.0

1.44k stars 124 forks source link

Do not throw NotReadyError for HTTP redirects #158

Closed g4b1nagy closed 9 years ago

g4b1nagy commented 9 years ago

Correct me if I'm wrong but HTTP redirects should also be considered successful.

bslatkin commented 9 years ago

Thanks for the patch! I have one comment. Let me know what you think.

g4b1nagy commented 9 years ago

You're perfectly right! allow_redirects=True is the way to go. Thanks for pointing that out. I've updated the patch.

I should also mention that this is needed in case the waitFor URL has a HTTP redirect. The actual test URLs are fetched via PhantomJS so they have no issue handling HTTP redirects.

bslatkin commented 9 years ago

Thanks!