Improve site diff link matching

bslatkin / dpxdt

Make continuous deployment safe by comparing before and after webpage screenshots for each release. Depicted shows when any visual, perceptual differences are found. This is the ultimate, automated end-to-end test.

https://dpxdt-test.appspot.com

Apache License 2.0

1.44k stars 124 forks source link

Improve site diff link matching #78

Closed steven-hadfield closed 10 years ago

steven-hadfield commented 10 years ago

Improve the regexes used to determine valid links to follow when performing a site diff.

bslatkin commented 10 years ago

Hey @steven-hadfield Thanks for sending along this patch! Looks like the tests weren't happy with the change. Can you take a look at the Travis CI output? Let me know how I can help.

steven-hadfield commented 10 years ago

Sorry about that. My fork was out of date which led to a bad merge. Should be fixed now.

bslatkin commented 10 years ago

Looks great overall. I'll merge this now. If you could add a comment on that one line I'd appreciate it and can merge that separately. Thank you for doing this!