search

bslatkin / effectivepython

Effective Python: Second Edition — Source Code and Errata for the Book
https://effectivepython.com
2.24k stars 718 forks source link

Item #37: Inner for loop should be indented #72

Closed panos73 closed 4 months ago

panos73 commented 4 years ago

First of all, thanks for a really great book. In the online version of the book, https://learning.oreilly.com/library/view/effective-python-90/9780134854717/ch05.xhtml#ch5 it is correctly mentioned "—the average_grade method now has a loop within a loop and is difficult to read", but the indentation does not reflect in the code.

cihati commented 4 years ago

image

bslatkin commented 4 years ago

This appears to be the same root cause as issue #63.

bslatkin commented 4 months ago

Duplicate of #63