search

bsm / openrtb

OpenRTB protocol defintions for Go
Other
288 stars 121 forks source link

SUA Browsers type is invalid #95

Closed Katsukiniwa closed 1 year ago

Katsukiniwa commented 1 year ago

I found minor bug on sua.

According to IAB reference, Browsers fileld of sua type is Array of BrandVersion, but current it is BrandVersion .

010

https://iabtechlab.com/wp-content/uploads/2022/04/OpenRTB-2-6_FINAL.pdf

https://github.com/bsm/openrtb/blob/b106b7e1c3d86ac819f2327c89031e68f8f35961/sua.go#L6

I want to fix this bug, but I don't have authorization to this repository, so please fix someone else.

If I'm wrong in pointing this out, please ignore this issue and close.

dim commented 1 year ago

@Katsukiniwa could you please fork and submit a pull request?

Katsukiniwa commented 1 year ago

@dim https://github.com/bsm/openrtb/pull/96

Thanks, I opened pull request!