While chaos testing some code that uses sarama-consumer in PartitionModeConsumer, we happened upon an area where the functionality doesn't correspond to the documentation. We were listening on the Errors() channel on the PartitionConsumer as documented, but we found that there was a race where some of the errors were surfacing on the Consumer's error channel and the rest on the partition consumer's. This patch brings the functionality in line with the docs by removing the loop in the consumer that drains/muxes the partition consumer's errors. Thanks!
While chaos testing some code that uses sarama-consumer in
PartitionModeConsumer, we happened upon an area where the functionality doesn't correspond to the documentation. We were listening on theErrors()channel on thePartitionConsumeras documented, but we found that there was a race where some of the errors were surfacing on the Consumer's error channel and the rest on the partition consumer's. This patch brings the functionality in line with the docs by removing the loop in the consumer that drains/muxes the partition consumer's errors. Thanks!