Fixed race condition when changing a notification after sending

bsm / sarama-cluster

Cluster extensions for Sarama, the Go client library for Apache Kafka 0.9 [DEPRECATED]

MIT License

1.01k stars 222 forks source link

Fixed race condition when changing a notification after sending #271

Closed blockchainian closed 6 years ago

blockchainian commented 6 years ago

Howdy, upstream contributors!

We have been using this awesome repo. I ran into a race condition yesterday in a test. Looked into it a bit and found that the notification was passed through the channel as a pointer and the creator modifies it after. This causes a race with the reader.

Made an one line change and would love to hear what you think! :)

dim commented 6 years ago

Thanks, but sarama-cluster is now deprecated in favour of https://github.com/Shopify/sarama/pull/1099

blockchainian commented 6 years ago

Thank you both for fixing my broken code! :)