search

bsm / sarama-cluster

Cluster extensions for Sarama, the Go client library for Apache Kafka 0.9 [DEPRECATED]
MIT License
1.01k stars 222 forks source link

README should be updated #276

Closed yeluyang closed 6 years ago

yeluyang commented 6 years ago

I meet trouble just like #99 , thanks @F21 .

But the solution in #99 is not the best solution, especially when you don't want receive all older msg.

My idea is as follow:

kafka will return a notifications via consumer.Notifications() when consumer init successfully in kafka.

you should wait this notifications and confirm field Type of it is equal to cluster.RebalanceOK.

if you don't wait the notifications, the msg inputted by producer maybe regard as an old msg before your new consumer init successfully, and the new consumer will never get the msg. this is why @F21 cannot received any msg.

My mother language is not English, so if there is any problem, please point it out.

dim commented 6 years ago

Sorry, the README is auto-generated, you need to update https://github.com/bsm/sarama-cluster/blob/master/README.md.tpl and run make doc. You will need go get -u github.com/dave/rebecca/cmd/becca

yeluyang commented 6 years ago

Sorry, the README is auto-generated, you need to update https://github.com/bsm/sarama-cluster/blob/master/README.md.tpl and run make doc. You will need go get -u github.com/dave/rebecca/cmd/becca

I have updated README.md.tpl and run make doc, please check. Thanks for your advice. @dim