search

bsmg / BeatSaberModInstaller

Automatically installs Beat Saber mods with a single click
218 stars 52 forks source link

Added BeatSaver OneClick installer #25

Closed Splamy closed 5 years ago

Splamy commented 5 years ago

[Do not merge yet, protocol discussions still open, issue: #21]

Basic oneclick downloading should work for songs, avatars, platforms and sabers.

When downloading a song, no new modinstaller window will open and the install will be done quietly in the background. However if one is already open a download start/success/error notification will appear in the status bar.

Windows UAC is a bit annoying since it pops up for each song install. My solution suggestion based on some googling would be to remove the default privilege request from the manifest and instead check at startup whether the modinstaller should be loaded and restart with admin privileges (should not be noticable to the user). There are a few other weird techniques, however I'm open for discussion here. For now I haven't changed anything in this pr yet.

Assistant commented 5 years ago

Tried it with ModelSaber, and it works great, however it saves the files with their names urlencoded. Would it be possible to decode that? Would be nice to have the popup show the proper name as well.

Splamy commented 5 years ago

I knew I forgot something, but as I see you already fixed it. Thanks for merging.

Oh and two things, I found a small spelling mistake https://github.com/beat-saber-modding-group/BeatSaberModInstaller/blob/bdb8f95a9876a9a6dc787ab84bd12af1f0965065/BeatSaberModManager/Core/OneClickInstaller.cs#L158 and this file is not in use an can be safely removed: https://github.com/beat-saber-modding-group/BeatSaberModInstaller/blob/master/BeatSaberModManager/Dependencies/RegHelper.cs

Maybe you can squeeze it into your next commit.