search

bsmg / ModAssistant

Simple Beat Saber Mod Installer
MIT License
2.5k stars 419 forks source link

OneClick Exception from BeatSaver - v1.0.23 #30

Closed xhuytox closed 5 years ago

xhuytox commented 5 years ago

image

Assistant commented 5 years ago

As the message suggests, it couldn't get the map details.

Could you post which beatmap that happens with?

sh-akira commented 5 years ago

I found same issue with this map: https://beatsaver.com/beatmap/3b0a

I don't know before but maybe JSON format on the beatsaver side has changed(at characteristics). https://beatsaver.com/api/maps/detail/3b0a

Assistant commented 5 years ago

Looks like you're right, the API response changed in lolPants/beatsaver-reloaded@751d8b74aaf1b39884127929cbe5f867d29fe6ca

There's nothing I can do right now but I'll fix it when I get a chance.

xhuytox commented 5 years ago

Yeah, this is happening for every map so the API response change makes sense. Thanks for the update.

fuji97 commented 5 years ago

I've updated the models in #31 and tested it, now works.

xhuytox commented 5 years ago

Can confirm that as of v1.0.24, OneClick is now working.